Repository navigation
chore(docker): supply docker compose via Bazel - #830
Merged
Merged
Conversation
mnoah1
force-pushed
the
mnoah1/pin-docker-compose
branch
from
October 9, 2026 18:00
a70880b to
fee529a
Compare
Use pinned rules_docker_compose 0.4.0 and its default Compose 5.5.1 for local stacks and Docker tests. Ruleset upgrades select the new release's default CLI without a separate version override. Upgrade rules_go to 0.59.0 and Gazelle to 0.53.0 while retaining Go 1.25.0. Invoke the upstream executable directly, resolve it through Bazel runfiles in tests, and use absolute Compose file paths. Use portable COPY and RUN chmod instructions so service image builds work without Buildx. Validate builds, unit tests, Docker integration and end-to-end suites, local startup and a landed demo request, and repository formatting and generation checks.
mnoah1
force-pushed
the
mnoah1/pin-docker-compose
branch
from
October 9, 2026 18:05
fee529a to
0128cca
Compare
mnoah1
changed the title
mnoah1
marked this pull request as ready for review
October 9, 2026 18:09
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
October 9, 2026 18:09
roychying
approved these changes
Oct 9, 2026
DivyanshGarg380
pushed a commit
to DivyanshGarg380/submitqueue
that referenced
this pull request
Oct 14, 2026
## Why? The new Stovepipe UI needs browser coverage against a real backend, in addition to its unit and component tests. Align both services' browser suites under `web/test/e2e/<domain>` so they follow the repository layout and reuse stack setup helpers. ## What? - Move the existing SubmitQueue browser suite into `web/test/e2e/submitqueue`, preserving its browser spec and Compose overlay. - Add `web/test/e2e/stovepipe` with real ingestion and seeded pagination data. Cover queue navigation and cursors, request-ID links and reloads, backend status summaries above history, refresh, empty queues, and accessibility. A summary with a newer state than the history verifies that the UI does not reconstruct status from events. - Share image loading, schema application, and port lookup helpers. Both browser runners use the Bazel-pinned Compose executable from uber#830. - Update Bazel targets and visibility, workspace entries, runner commands, and test documentation for the new layout. Tests emit queue and request-page screenshots as Bazel test outputs. ## Test Plan Latest validation passed all 32 targets, including both services' real-stack browser suites: ```sh ./tool/bazel test //web:check //web/test/e2e/submitqueue:web_test //web/test/e2e/stovepipe:web_test --test_output=errors ``` Repository formatting, lint, module tidy, and Gazelle checks also passed. Browser tests require a running Docker daemon; Bazel supplies Compose and the browser. ## Stack 1. uber#842 — shared-package refactoring 2. uber#837 — Stovepipe frontend 3. uber#838 — browser coverage and E2E organization 4. uber#844 — host logging integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Host-installed Compose versions can reject flags such as
up --wait, breaking local stacks and Docker tests.What?
rules_docker_compose0.4.0 and its default Compose 5.5.1 directly from Bazel and test runfiles. Upgrade both throughMODULE.bazel.Test Plan
Build, 134 unit targets, 13 Docker integration/e2e targets, documentation, lint, Gazelle, tidy, and mock checks passed. Verified startup, a demo request reaching landed, and shutdown without Buildx or a host Compose plugin.
Unit checks used isolated Git configuration and pinned helpers. Live GitHub cases skipped without credentials. The shared verifier could not complete coverage/lint checks; repository checks passed.
To try locally:
Revert Plan
Revert this PR to restore host-selected Compose and previous build-rule versions.