feat(stovepipe): Add project build identity - #747
Draft
prathshenoy wants to merge 2 commits into
Draft
prathshenoy wants to merge 2 commits into
prathshenoy wants to merge 2 commits into
Conversation
Summary: Persist the winning terminal build identity in the terminal request-history entry, atomically with the request outcome, so record can later resolve final artifacts without a Build reverse index. Test Plan: ./tool/bazel test //stovepipe/controller/buildsignal:go_default_test //stovepipe/core/messagequeue:go_default_test //stovepipe/extension/storage/mysql:go_default_test --test_output=errors Revert Plan: Revert this commit to stop persisting terminal build identity. Jira Issues: None
prathshenoy
changed the base branch from
main
to
prath.shenoy/stovepipe-project-result-build
September 28, 2026 16:24
1 task done
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-project-result-input
branch
from
September 28, 2026 16:26
89db583 to
9cc7879
Compare
prathshenoy
changed the title
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-project-result-input
branch
3 times, most recently
from
September 28, 2026 16:50
953ec5d to
b4a83be
Compare
Summary: - Pass the terminal build ID selected by buildsignal to project-result resolvers. - Load the terminal request-history entry before recording project facts. - Let repository-specific resolvers retrieve artifacts from the build that established the terminal outcome without a request-to-build reverse lookup. Test Plan: ./tool/bazel test //stovepipe/controller/record:go_default_test //stovepipe/core/requestlog:go_default_test //stovepipe/extension/projectresult/noop:go_default_test --test_output=errors Revert Plan: Revert this commit if project-result resolution cannot load terminal build identity or causes record-stage failures. Reverting restores the prior resolver input and allows terminal requests to continue recording whole-repository facts.
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-project-result-input
branch
from
September 28, 2026 17:51
b4a83be to
543d05e
Compare
prathshenoy
force-pushed
the
prath.shenoy/stovepipe-project-result-build
branch
12 times, most recently
from
September 29, 2026 00:58
039cf79 to
55cc960
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
./tool/bazel test //stovepipe/controller/record:go_default_test //stovepipe/core/requestlog:go_default_test //stovepipe/extension/projectresult/noop:go_default_test --test_output=errors
Revert Plan
Revert this commit if project-result resolution cannot load terminal build identity or causes record-stage failures. Reverting restores the prior resolver input and allows terminal requests to continue recording whole-repository facts.
Issues
Stack