refactor(storage): give the orchestrator its own aggregate, keeping store contracts at domain level - #743
Merged
behinddwalls merged 1 commit intoSep 25, 2026
Conversation
roychying
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
September 23, 2026 17:49
roychying
added this pull request to stack #742
September 23, 2026 17:49
roychying
force-pushed
the
chenghan.ying/sq-storage-2-orchestrator
branch
from
September 23, 2026 19:10
d32355d to
4d3bdf6
Compare
roychying
force-pushed
the
chenghan.ying/sq-storage-2-orchestrator
branch
from
September 23, 2026 19:23
4d3bdf6 to
f6acabf
Compare
behinddwalls
approved these changes
Sep 25, 2026
…tore contracts at domain level
behinddwalls
force-pushed
the
chenghan.ying/sq-storage-2-orchestrator
branch
from
September 25, 2026 02:01
f6acabf to
ea32aa1
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
Second half of the split: with the gateway's four moved, the remaining nine are the orchestrator's, and the domain package should be left holding only what both services genuinely share.
What?
submitqueue/orchestrator/extension/storage/gains itsFactory, a nine-accessorStorage, the nine MySQL implementations and the nine.sqlfiles.submitqueue/extension/storage/is now the contract layer: thirteen store interfaces, their mocks, the error vocabulary,Configand the README.Not promoted to
platform/— it is not cross-domain.stovepipe/extension/storage/storage.goalready declares its own verbatim copy of the same symbols, so a per-domain error vocabulary is the existing pattern.submitqueue/core/is rebound, not relocated: files naming an aggregate name one service's. Relocating those packages is the next branch.Test Plan
go build ./...,go vet ./..., and all four repo checks clean;make test122/122.queueshardstill reports 25 tables.Issue