Add support for Google Cloud#357
Merged
Merged
Conversation
- Changed CLOUD_PING URI to the correct URI - Changed system from web scraping and parsing table into a GET request to the API - Deleting the parse_table method - Removed beautifulsoup import, not used anymore - Rewritten test to reflect the changes
…blic on ODbL licence. - finding the electricitymaps zone of a region from its coordinates - download its respective csv - process the csv by using the data from 1 year ago Fixes: - failed to deploy from missing README.md file on the generated dockerfile -
- added typing
…enchmarks folder to allow benchmarking in GCP
…ing remote cli deployment
# Conflicts: # caribou/data_collector/utils/constants.py
…hboard through an API call, and returns a zone-to-zone median latency. Get distribution is modified to allow it to work, but functionality needs to be further tested.
…rfile generation" This reverts commit 58789de.
…storical_csv.py empty file
# Conflicts: # caribou/data_collector/utils/constants.py # caribou/data_collector/utils/ec_maps_zone_finder/README.md # caribou/data_collector/utils/latency_retriever/gcp_latency_retriever.py # poetry.lock # pyproject.toml
…ten and sync nodes cannot be invoked
…unt to not be invoked during workflow deletion
…ly took 20 minutes now takes 18 seconds
…y value is specified.
Danidite
requested changes
Aug 6, 2025
Danidite
left a comment
Contributor
There was a problem hiding this comment.
Overall it looks great, amazing work! However I have a few questions and comment that I think may be problematic or need to be addressed.
Danidite
approved these changes
Aug 7, 2025
This comment was marked as duplicate.
This comment was marked as duplicate.
…emented paged log retrieval, fixed missing aws permission for lambda functions
…vice account generation for gcp
Danidite
approved these changes
Aug 11, 2025
Danidite
left a comment
Contributor
There was a problem hiding this comment.
The new changes looks great, I do have a few very minor comments that may be a nice to have.
… iam policy, removed service account deletion in deploying remote cli, implemented gcp remote cli that is invoked using pub/sub
… each subscription, removal of cli pubsub topic
…ment to the quota limiter
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Major Changes] Added support for Google Cloud Platform (GCP) cloud provider. Key components have been refactored to handle both AWS and GCP resources, selectable via an environment variable "CARIBOU_DEFAULT_PROVIDER".
Key Changes & Features:
Multi-Cloud RemoteClient Architecture:
GCP Resource Management:
Framework Tooling Updates:
Data collection
Unit Tests:
How to Use:
To target GCP for deployment or other commands, set the following environment variables before running the caribou CLI:
To switch the target back to AWS, use the following command:
Further instructions are provided in the INSTALL.md file in the project's directory.
Remaining Work & Known Issues:
This is an initial implementation. Further testing on more workflows is needed.