feature: added AppSyncLambdaAuthorizer#642
Open
Yummy-Yums wants to merge 5 commits into
Open
Conversation
Author
|
@armanbilge pleas review |
Yummy-Yums
changed the title
Chingles2404
approved these changes
Jun 22, 2026
Chingles2404
left a comment
Chingles2404
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Thanks for your hard work!
armanbilge
requested changes
Jun 26, 2026
armanbilge
left a comment
armanbilge
left a comment
Member
There was a problem hiding this comment.
Looks good, noticed one thing!
| sealed abstract class AppSyncLambdaAuthorizerEvent { | ||
| def authorizationToken: String | ||
| def requestContext: AppSyncRequestContext | ||
| def requestHeaders: Map[String, String] |
Member
There was a problem hiding this comment.
If these are HTTP headers, we can use CIString because they are case-insensitive.
Suggested change
| def requestHeaders: Map[String, String] | |
| def requestHeaders: Map[CIString, String] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#48 : adds AWS Lambda event type AppSynclambdaAuthorizer