Repository navigation
feat(settings): auto-check-for-updates toggle on every host (#58 slice) - #65
Merged
Merged
Conversation
The silent launch + 4-hour update checks were invisible to the user;
the Raycast study called that out (updates behavior belongs in the
open). PRODUCT-SPEC §8's Settings menu gains a checkable
Automatically Check for Updates item (config `auto-check-updates`,
default "1"): silent checks skip when off, the manual Check for
Updates… item always runs and ignores the throttle too.
- macOS: Settings-menu Toggle bound to AppModel.autoCheckUpdates;
bootstrap reads the setting before the silent check; persists via
set_setting.
- Windows: ToggleMenuFlyoutItem + auto_check_updates_ member, loaded
over the backend get_setting RPC when the backend comes up, gated at
the top of RunSilentUpdateCheck, persisted via SaveSettingAsync.
- Linux: stateful win.auto-check-updates Gio action (popover menus
render the checkmark), gate at the top of on_update_auto_check,
persisted through save_setting, initial state synced when the
startup get_settings lands.
Backend: set_setting's grammar whitelists the key ("0"/"1") and — the
actual persistence bug this slice caught — the config writer's key
list now carries it too; set_setting round-trips are pinned by a
backend-test case. UPDATE.md documents the toggle; DATA-FORMAT §7
lists the key.
The two appended functions landed after the winrt::RivetHost::implementation closing brace, where MainWindow is just a name — CI caught the scope error.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #58. Third confirmed Raycast-study slice (更新行为显性化).
What
Settings menu gains a checkable Automatically Check for Updates on all three hosts (config
auto-check-updates, default on):AppModel.autoCheckUpdates, bootstrap reads before the silent check;ToggleMenuFlyoutItem→ member +RunSilentUpdateCheckgate, loaded via the backend get_setting RPC on backend-up;win.auto-check-updatesGio action (popover renders the checkmark), gate inon_update_auto_check, synced when startup settings land.Backend contract
set_settingwhitelists the key ("0"/"1") and the config writer's key list now carries it — the writer's hardcoded list was silently dropping unknown-but-whitelisted keys; pinned by a backend-test round-trip case.Verification
auto-check-updates = 0to config.ini, RPC dispatch visible in diagnostics;raco rivet buildclean.