Skip to content

linux runtime: build on hosts without SOCK_CLOEXEC #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turinglambdaai merged 2 commits into from
Oct 8, 2026
Merged

linux runtime: build on hosts without SOCK_CLOEXEC #126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc7dcd3
linux runtime: build on hosts without SOCK_CLOEXEC
turinglambdaai Oct 1, 2026
f48e4e4
Close fallback socket descriptors on setup failure
Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion platform/linux/runtime/backend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include <cerrno>
#include <cstring>
#include <exception>
#include <initializer_list>
#include <memory>
#include <mutex>
#include <stdexcept>
Expand Down Expand Up @@ -67,13 +68,30 @@ struct SocketEndpoints {

SocketEndpoints create_socket_endpoints() {
int fds[2]{-1, -1};
if (::socketpair(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0, fds) != 0) {
#if defined(SOCK_CLOEXEC)
int const rc = ::socketpair(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0, fds);
#else
int const rc = ::socketpair(AF_UNIX, SOCK_STREAM, 0, fds);
#endif
if (rc != 0) {
throw std::runtime_error("socketpair failed: " +
std::string(std::strerror(errno)));
}

UniqueFd native(fds[0]);
UniqueFd server_read(fds[1]);
#if !defined(SOCK_CLOEXEC)
// Platforms without SOCK_CLOEXEC (macOS): set the flag on both ends right
// after the pair exists. Own the descriptors first so an fcntl failure
// cannot leak either endpoint while the exception unwinds.
for (int const fd : {native.get(), server_read.get()}) {
int const flags = ::fcntl(fd, F_GETFD, 0);
if (flags < 0 || ::fcntl(fd, F_SETFD, flags | FD_CLOEXEC) != 0) {
throw std::runtime_error("fcntl(FD_CLOEXEC) failed: " +
std::string(std::strerror(errno)));
}
}
#endif
UniqueFd server_write(::dup(server_read.get()));
if (server_write.get() < 0) {
throw std::runtime_error("dup failed: " +
Expand Down
Loading