Repository navigation
distribution: drop crypto/all; pin the provider to libcrypto - #111
Merged
Merged
Conversation
Requiring crypto/all loads every factory module, and some of them run their FFI loads in their module bodies — the gmp factory kills the process at import time on hosts without libgmp. Rivet's manifest needs only SHA-256 and Ed25519, which the libcrypto provider (bundled by the official Racket distributions on every desktop target) fully satisfies, so the provider set is pinned there and crypto/all is gone entirely. Found packaging a real app for macOS: the CI-built bundle died at boot on a clean install before any manifest code ran.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #110, which stopped instantiating every factory but still required
crypto/all— and requiring it loads every factory module, some of which run their FFI loads in their module bodies. The gmp factory kills the process at import time on hosts without libgmp, so the packaged macOS app from #110's verification still died at boot:Rivet's manifest needs only SHA-256 and Ed25519, which the libcrypto provider fully satisfies (the official Racket distributions bundle OpenSSL on every desktop target). This drops
crypto/allentirely and pins(crypto-factories (list libcrypto-factory)), also simplifyinged25519-factories.Verification
raco test tests/distribution.rkt: 20/20.