feat: add "mutuals" and "follow back" to follow button text

[ThatOneCalculator]

[gemini-code-assist]

Summary of Changes

Hello @ThatOneCalculator, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the social interaction UI by providing more descriptive text for the follow button on profile pages. The update allows users to quickly discern if they have a mutual following relationship or if they are being followed back by a profile, moving beyond the generic 'Follow' or 'Following' states. This improves clarity and user engagement on the platform.

Highlights

• New String Resources: Added 'follow_back' and 'mutuals' string resources to both the feature/profile and ui/timeline modules for improved user interface messaging.
• Enhanced Follow Button Logic: The ProfileViewerState composable now dynamically displays 'Mutuals' when both the viewer and the profile follow each other, and 'Follow Back' when the profile follows the viewer but the viewer does not reciprocate.
• Improved User Experience: The changes provide clearer social interaction cues on profile pages, making it more intuitive for users to understand their relationship with other profiles.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds new states 'Mutuals' and 'Follow Back' to the follow button. The changes involve adding new string resources and updating the logic in ProfileViewerState.kt to display the correct button text based on the follow status. My review includes suggestions to improve maintainability by centralizing duplicated strings, and to enhance code readability in Kotlin by using a when expression and wildcard imports.

[tunjid]

How do you feel about some alliteration? "Following", "Follow", "Follow back" or "Friends"? You're right that there should be some verbiage about mutual following.

[tunjid]

There's also that "Follows you" text underneath that becomes redundant when following is mutual though

[ThatOneCalculator]

How do you feel about some alliteration? "Following", "Follow", "Follow back" or "Friends"? You're right that there should be some verbiage about mutual following.

So this would only be changing "mutuals"? I think that it should stay as mutuals, given that's very common verbage on Bluesky and other social media platforms, and there may be a world in which Bluesky adds a proper friends system for DMs or something else later.

There's also that "Follows you" text underneath that becomes redundant when following is mutual though

To be honest, I never even noticed that until after making this PR. It's not very visible since there's no contrast to the text, I agree that it should be remove.

[tunjid]

SG, there's a design opportunity here. The "Follows you" shows if you don't reciprocate the follow, so it doesn't go away wholesale.

If the text does switch to "Mutuals", some design element should link the two texts. One sticking point is "mutuals" is not a verb, and neither is "friends" so "friends" is definitely not making it. "follow" and "following" are verbs and that matters from a UI/UX POV. Maybe "follows you" becomes a handshake emoji, or maybe you get an animation for the two fusing to add some charm. I'll think it over some.

You could also leave the button as is so the verbs don't change, but "follows you" becomes "mutuals" with an emoji, or other design trinket.