Document app-first Terminal.Gui agent design loop, snapshot contract, and self-improvement pipeline#5456
Document app-first Terminal.Gui agent design loop, snapshot contract, and self-improvement pipeline#5456Copilot wants to merge 4 commits into
Conversation
|
@copilot needs to be inherently self improving. In developing tuirec, as agents used it, I would regularly have them what they leaned and how tuirec and its guidance could be improved. We need this concept built in here. Some sort of automated pipeline back to the agent plugin repository. Eg file gh issues (without spamming). |
Addressed in b3725a1. I updated the proposal with a built-in self-improvement feedback loop: structured lessons in |
|
@copilot this is too narrowly focused on views. It should encapsulate full TG TUI apps. The initial focus should be on TG. Later we may expand to any dotnet TUI framework and later to any tui framework. |
Addressed in 5138375. I broadened the proposal to target full Terminal.Gui app development (not just views), updated the design-loop step to cover app workflows/state/commands, and added phased rollout scope: Terminal.Gui first, then other .NET TUI frameworks, then broader TUI frameworks. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5138375585
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// </summary> | ||
| /// <remarks> | ||
| /// This output is intended for terminal replay and may include incremental escape-sequence behavior. | ||
| /// Prefer <see cref="ToString"/> as the canonical source for snapshot/golden assertions. |
There was a problem hiding this comment.
Keep ANSI snapshots as the visual golden source
For visual snapshot/design-review assertions, this guidance would make tests miss any regression that only changes attributes, styles, or OSC8 links: DriverImpl.ToString() appends only each cell's Grapheme, while the current snapshot helper records IDriver.ToAnsi() specifically because it preserves the byte-exact rendered look. If a view changes from red to blue, the proposed ToString() golden stays identical, so please qualify this as text-only snapshots or keep ToAnsi() as the canonical source for visual goldens.
Useful? React with 👍 / 👎.
Fixes
Issue linkage is handled automatically by the system.
Proposed Changes/Todos
tuirecworkflow patterns and the winprint design-loop proposal.docfx/docs/agent-design-loop.mddefining:gui-cs/tui-dev-skillsstyle repo structure (plugins/tui,agents/tui-dev,skills,src/tools)tui-designscope updated to iterative app UX/layout refinementdocfx/docs/toc.ymldocfx/docs/index.mdTerminal.Gui/Drivers/IDriver.csXML docs:ToString ()is the canonical full-grid capture for deterministic snapshotsToAnsi ()is terminal replay/output oriented and not the golden snapshot sourcetui-session-reportincludes structured lessons learnedagent-feedbacklabeling to avoid spamPull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)