Repository navigation
iOS: artist photos on the Artists tab - #13
Merged
Merged
Conversation
Each row of the Artists list now leads with the artist's photo in a 40pt circle, as on Home's crate. The list needs every artist's photo, so the v1 /artists list is walked a page at a time (100 is its cap; 718 artists = 8 requests) once per session, after the names are on screen, and cached on AppModel beside the artist list (cleared on logout; an empty walk isn't cached, so it retries). Home's crate reads from that cache once it exists. The paging stop rule is pure and tested (short page, total reached, a 20-page cap against a bad total). ArtistPortrait moves out of HomeView into Theme/Components, shared. iOS only; the Mac sidebar list is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VriHZgxEZZHunPFyTvTmjt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each row of the Artists list now leads with the artist's photo in a 40pt circle, matching Home's crate.
/artistslist is fetched 100 at a time (its cap; 718 artists means 8 requests). This happens once per session, after the names are on screen, through the existing token bucket. The result is cached onAppModelnext to the artist list and cleared on logout. An empty result isn't cached, so the next open retries. Home's crate reads from that cache once it exists.Catalog.nextArtistPageOffset, pure and tested): stop on a short page, when the reportedtotalis reached, or at a 20-page cap that guards against a bad total.ArtistPortraitmoves intoTheme/Components, shared.Verified: unit tests pass, including the new
CatalogArtistPagingTests; both schemes build warning-free; installed on the real Duo.🤖 Generated with Claude Code
https://claude.ai/code/session_01VriHZgxEZZHunPFyTvTmjt