Repository navigation
iOS: the crate shows artist photos, and names fit - #12
Merged
Merged
Conversation
Tim didn't like initials on the crate tiles, or names cut off. The v1 catalog carries a real 800x800 photo for every artist (avatarImage.url; sampled six, zero-show artists included — all distinct photos), keyed by the same ids as the legacy artist list, and /artists?ids= fetches the crate's nine in one request. Catalog.artistAvatars parses it (pure, tested); Home fetches after the sample lands; a failure or a missing photo keeps the monogram. Skipped on -UITEST (fake ids). The tile is now a circular photo (Apple Music's artist shape, apart from the square show covers above it) with the name below: up to three lines, shrinking to 85% before truncating — full names for ~98% of the catalog — two lines always reserved, tiles stretched to their row. iOS only; the Mac crate is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VriHZgxEZZHunPFyTvTmjt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Home's crate tiles now show each artist's photo instead of initials, and long names wrap instead of truncating.
avatarImage.url; sampled six, including zero-show artists, all distinct photos). It uses the same artist IDs as the legacy list, and/artists?ids=fetches the crate's nine in one request.Catalog.artistAvatarsparses it (pure, unit-tested). A failure or a missing photo keeps the monogram. Skipped on-UITESTruns, whose stub IDs are fake.Verified: unit tests pass, including the new
CatalogArtistAvatarsTests; both schemes build warning-free; tile layout checked in the iPhone 17 Pro simulator (monogram fallback); installed on the real Duo.🤖 Generated with Claude Code
https://claude.ai/code/session_01VriHZgxEZZHunPFyTvTmjt