Skip to content

Make random-binary non-recursive#3209

Closed
hyanwong wants to merge 1 commit into
tskit-dev:mainfrom
hyanwong:non-recursive-random-binary
Closed

Make random-binary non-recursive#3209
hyanwong wants to merge 1 commit into
tskit-dev:mainfrom
hyanwong:non-recursive-random-binary

Conversation

@hyanwong

@hyanwong hyanwong commented Jun 9, 2025

Copy link
Copy Markdown
Member

Fixes #2626

@codecov

codecov Bot commented Jun 9, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (e81ee40) to head (ce2e1ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3209   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files          28       28           
  Lines       31978    31987    +9     
  Branches     5872     5875    +3     
=======================================
+ Hits        28662    28671    +9     
  Misses       1886     1886           
  Partials     1430     1430           
Flag Coverage Δ
c-tests 86.66% <ø> (ø)
lwt-tests 80.38% <ø> (ø)
python-c-tests 88.18% <ø> (ø)
python-tests 98.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
python/tskit/combinatorics.py 99.37% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeromekelleher

Copy link
Copy Markdown
Member

A rushed, vibe coded update to a subtle algorithm that has not been statistically validated is not helpful. What's the point of this? Increasing the stack depth is easily done, and for all we know this update completely destroys the statistical properties. I don't actually care if it doesn't, the point is that we all have better things to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove recursion from generate_random_binary

2 participants