Allow Y axis on RHS of SVG plot#3201
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3201 +/- ##
=======================================
Coverage 89.63% 89.63%
=======================================
Files 28 28
Lines 31978 32000 +22
Branches 5872 5877 +5
=======================================
+ Hits 28662 28684 +22
Misses 1886 1886
Partials 1430 1430
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Seems useful - if you don't like to overloaded arg then adding another arg that is |
|
I'm happy to overload the argument, and just allow "left" and "right". |
|
Should we default to having a Y axis be shown? I think there was an issue about this. |
jeromekelleher
left a comment
There was a problem hiding this comment.
LGTM. minor logic tweak suggested

This is a bit trivial, but it was the easiest way to make nice tanglegram plots for sc2ts, in which trees are rotated in different directions (see below). So I thought as I had done the work, I might as well see if it is sensible to include in tskit? Otherwise I'll just keep it on my own branch.
Note that this allows
y_axis=Trueory_axis="right", which is a bit yucky. No tests either, in case it seems a silly idea: