Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SJ2.1sits atx=5.3999378whileR3.2sits atx=5.4, so the recovered trace between them is skewed by about 6e-5. That is far below the routing grid but far above the 1e-9 epsilon used to classify axis-aligned segments, so the segment matches neither fast path insegmentIntersectsRectand is reported as colliding with nothing. The trace then runs straight throughschematic_component_8.Two tests pin current behaviour: the unit-level miss in
segmentIntersectsRect, and the resulting trace crossing a chip it does not terminate on. A truly diagonal segment is left out of scope. Test only, nolib/changes. The fix is in #1100.