Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR was closed because it has been inactive for 1 day since being marked as stale. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Silkscreen text currently drops the converter's
mirroredprop during rendering. Emit it as Circuit JSONis_mirrored, preserving true, false, and omission, including imported footprint and pin-row labels.Includes a visual regression and geometry assertions for both layers and parent layer flips. Found while auditing tscircuit/circuit-json-to-tscircuit#89; the converter mapping already exists, so no duplicate converter change is needed.
Depends on tscircuit/props#885. A narrow development-only Bun patch mirrors that props change so local/CI tests are reproducible. This PR is draft until the props release is available; replace the patch with that release before merging.
Validation: 18 related silkscreen/fabrication tests pass; package build including declarations passes. The new regression test and its imported library/fixture dependencies also pass TypeScript checking.