Skip to content

Fix imported schematic symbol text moving separately in MatchPack - #4166

Closed
KrishnaX12 wants to merge 9 commits into
tscircuit:mainfrom
KrishnaX12:fix/custom-symbol-text-matchpack
Closed

KrishnaX12 wants to merge 9 commits into
tscircuit:mainfrom
KrishnaX12:fix/custom-symbol-text-matchpack

Conversation

@KrishnaX12

Copy link
Copy Markdown
Contributor

Problem

Imported symbol text was not associated with its schematic component. During MatchPack auto-layout, symbol artwork moved while reference/value labels stayed at the original position. This reproduces with the real SWRA117D antenna symbol imported from SQFMI Watchy.

Changes

  • Associate schematic text inside a symbol with its owning schematic component.
  • Add the Watchy antenna circuit-json symbol fixture, a minimal automatic-layout regression test, and a visual schematic snapshot.

Verification

  • Repro branch test fails before the fix because the antenna labels lack schematic_component_id.
  • Fix branch test passes and its snapshot shows readable labels beside the antenna.
  • Related custom-symbol test passes; TypeScript and Biome checks pass.

Repro-only branch: main...KrishnaX12:repro/custom-symbol-matchpack

This is a draft pending maintainer review.

@vercel

vercel Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tscircuit-core-benchmarks Ready Ready Preview Sep 27, 2026 9:26am UTC

Request Review

@KrishnaX12 KrishnaX12 closed this Sep 27, 2026
@KrishnaX12
KrishnaX12 deleted the fix/custom-symbol-text-matchpack branch September 29, 2026 15:43

This branch was successfully deployed

1 active deployment
Preview — 89000c5f Deployed Sep 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant