fix: declare opendmarc_policy_fetch_fo() in dmarc.h.in (#407)#408
Merged
thegushi merged 13 commits intoJun 6, 2026
Merged
Conversation
…project#407) The function was implemented and documented but never declared in the public header, causing a build failure on Clang 15+ where implicit function declarations are an error rather than a warning.
Catches Clang-strict build failures (like the missing opendmarc_policy_fetch_fo declaration in issue trusteddomainproject#407) that go undetected on the Linux/GCC job.
libmilter is not a standalone Homebrew formula; it comes from sendmail.
Neither libmilter nor sendmail exist as Homebrew formulae; build from the sendmail source tarball instead.
libmilter.a builds in the current directory, not obj.*/; only mfapi.h and mfdef.h need to be installed, not the internal sendmail.h.
mfapi.h typedef's bool which conflicts with C23 where bool is a keyword.
Same mfapi.h bool conflict as miltertest; gcc defaults to gnu23 on this runner.
This was referenced Jun 6, 2026
thegushi
added a commit
to thegushi/OpenDMARC
that referenced
this pull request
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opendmarc_policy_fetch_fo()was implemented inlibopendmarc/opendmarc_policy.cand documented, but its declaration was never added todmarc.h.inopendmarc_policy_fetch_*int-out-param functionsCloses #407
Test plan