reports: use basename for report attachment filename#406
Merged
thegushi merged 1 commit intoJun 5, 2026
Merged
Conversation
The attachment Content-Disposition was using the full spool file path ($gzipfile) as the filename, causing report attachments to be named e.g. '_var_db_opendmarc_example.com!domain.com!begin!end.xml.gz' instead of 'example.com!domain.com!begin!end.xml.gz'. File::Basename is already imported; use it.
thegushi
added a commit
that referenced
this pull request
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attachment
Content-Dispositionheader was using the full spool file path as the filename, so recipients would receive attachments named like:instead of the RFC 7489 section 7.2 compliant:
\$gzipfileis the full path (\$workdir . "/" . \$repdom . "!" . \$domain . ...).File::Basenameis already imported at the top of the script; this fix wraps the filename inbasename().