Fix exported prefix macro#62
Open
MesTTo wants to merge 2 commits into
Open
Conversation
The single test compared the macro's output against prefix_non_proper, the very primitive the macro calls. Add structural assertions that hold independently of how the offset is derived (non-empty strict prefix of the encoded span), and a proper-prefix case: a pattern with a variable stops before the variable and its path is exactly the lead-in it shares with the ground instantiation.
MesTTo
force-pushed
the
pr/mork-prefix-macro-api
branch
from
5b7f434 to
cb27dd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the already-exported
prefix!macro usable from integration tests and downstream callers.The branch adds the small
prefix::Prefixwrapper expected by the macro, qualifies macro dependencies through$crate, and derives the stored prefix through the existingExpr::prefix_non_proper()behavior.Validation:
cargo +nightly-2026-06-01 test -p mork --test prefix_macrowithRUSTFLAGS='-C target-cpu=native'andCARGO_WORKSPACE_DIRset to the branch worktreecargo +nightly-2026-06-01 test -p mork --libwithRUSTFLAGS='-C target-cpu=native'rustfmt --checkonkernel/tests/prefix_macro.rsjscpdonkernel/src/lib.rs,kernel/src/space.rs, andkernel/tests/prefix_macro.rsgit diff --check