Skip to content

Add PR validation workflow#4

Merged
trippwill merged 7 commits into
mainfrom
codex/add-pr-validation-workflow
Jun 7, 2025
Merged

Add PR validation workflow#4
trippwill merged 7 commits into
mainfrom
codex/add-pr-validation-workflow

Conversation

@trippwill
Copy link
Copy Markdown
Owner

Summary

  • install nightly Neovim in GitHub Actions for PRs
  • install plenary.nvim for tests
  • install Rust and use vimcats to verify docs
  • update README to require nvim 0.11+

Testing

  • bash ./test.sh (fails: E492: Not an editor command: PlenaryBustedDirectory)

https://chatgpt.com/codex/tasks/task_e_68442e84a3f0832e9e093800fe601227

Copilot AI review requested due to automatic review settings June 7, 2025 12:35

This comment was marked as outdated.

trippwill and others added 4 commits June 7, 2025 13:53
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Charles Willis <5862883+trippwill@users.noreply.github.com>
revert

Signed-off-by: Charles Willis <5862883+trippwill@users.noreply.github.com>
Signed-off-by: Charles Willis <5862883+trippwill@users.noreply.github.com>
@trippwill trippwill requested a review from Copilot June 7, 2025 13:00

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Charles Willis <5862883+trippwill@users.noreply.github.com>
@trippwill trippwill requested a review from Copilot June 7, 2025 13:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a GitHub Actions workflow to validate pull requests by installing dependencies and running docs checks and tests.

  • Introduce a pr.yml workflow that sets up Neovim nightly, Rust toolchain, and caching for Cargo and Plenary.nvim
  • Add a docs verification step using vimcats
  • Update README to bump required Neovim version to 0.11+

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
doc/swapdiff.nvim.txt Simplified list-item wording but removed list markers
README.md Updated Neovim requirement from 0.9 to 0.11
.github/workflows/pr.yml New PR validation workflow with setup, caching, docs check, and tests
Comments suppressed due to low confidence (2)

doc/swapdiff.nvim.txt:432

  • The leading '-' list marker was removed, which may break vimdoc list formatting. Consider restoring the '-' prefix for consistent list items.
PrintLogSink writes log messages to the Neovim message area using `print()`.

README.md:15

  • The list bullet ('- ') was dropped before **Requirements:**, causing inconsistent Markdown list formatting. Re-add - **Requirements:**.
**Requirements:** Neovim 0.11+

Comment thread .github/workflows/pr.yml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Charles Willis <5862883+trippwill@users.noreply.github.com>
@trippwill trippwill merged commit 49fdc4c into main Jun 7, 2025
1 check passed
@trippwill trippwill deleted the codex/add-pr-validation-workflow branch June 7, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants