RFC: predicates for host exclusion in checks#188
Draft
balanza wants to merge 1 commit into
Draft
Conversation
balanza
force-pushed
the
check-exclusion-predicate
branch
2 times, most recently
from
9adc4d6 to
c2ff6f5
Compare
balanza
force-pushed
the
check-exclusion-predicate
branch
from
c2ff6f5 to
e2f9db6
Compare
nelsonkopliku
approved these changes
May 18, 2026
nelsonkopliku
left a comment
nelsonkopliku
left a comment
Member
There was a problem hiding this comment.
Looks good to me, Emanuele.
Just a tiny minor comments.
| // Keys are opaque strings agreed between Trento Web (producer) and | ||
| // check authors (consumers); the contract on which keys exist and | ||
| // what they mean lives outside the proto file. | ||
| map<string, google.protobuf.Value> host_data = 3; |
Member
There was a problem hiding this comment.
thought: what about stripping the host reference from this new piece of information, and keep the target wording.
Instead of host_data we could have data,target_data,metadata, target_metadata
| id: "ABC123" | ||
| name: Check that does not apply to majority maker nodes | ||
| exclude: | | ||
| host["is_majority_maker"] == true |
Member
There was a problem hiding this comment.
thought: we could consider consistently advertise dot access like host.is_majority_maker.
IIRC accessing a non existent entry would return () anyway, right?
Member
Author
There was a problem hiding this comment.
AFAIK given it's a map should be accessed by index, but I have to test it.
balanza
force-pushed
the
check-exclusion-predicate
branch
from
e2f9db6 to
dffa5a9
Compare
balanza
force-pushed
the
check-exclusion-predicate
branch
from
dffa5a9 to
ed53b4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual