Fix escaped trailing pipes being removed from table cells - #725
Merged
nicholasserra merged 2 commits intoSep 14, 2026
Merged
Conversation
Collaborator
|
Thanks! If you can go in and fix the CHANGES format i'll hit merge |
Contributor
Author
|
Fixed |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the
tablesextra, an escaped pipe at the end of a row is stripped as if it were the optional closing table border. For example:The heading renders as
Operator \and the data cell as\, instead ofOperator |and|._split_rownow preserves an escaped final pipe so the existing cell unescaping can handle it.The regression fixture covers headers and body rows, optional leading/trailing borders, repeated escaped pipes, alignment, emphasis, and empty cells. It fails before the implementation change and passes afterward.
Validation on macOS with Python 3.13 and all optional dependencies installed:
cd test && ../.venv/bin/python test.py -- -knownfailure: 270 tests pass. The runner retains its standard known-failure and Pygments-version exclusions..venv/bin/python test/test_redos.py: all 7 checks pass.pycodestyle --difffor the changed Python lines andgit diff --check: pass.Prepared with OpenAI Codex assistance.