Skip to content

SCTP support#82

Open
swordfeng wants to merge 2 commits into
traviscross:masterfrom
swordfeng:sctp-support
Open

SCTP support#82
swordfeng wants to merge 2 commits into
traviscross:masterfrom
swordfeng:sctp-support

Conversation

@swordfeng

Copy link
Copy Markdown
Contributor

I added codes about SCTP in curses.c and select.c this time, and got SIGPIPE when MTRing to a non-existent address (which causes a loop route between two routers).
I modified net.c, to avoid SIGPIPE, but I don't know if I'm doing the right thing, as I'm not familiar with the whole program.

@LionNatsu

Copy link
Copy Markdown

How about the bug now?

@LionNatsu

Copy link
Copy Markdown

ref.: #81

@swordfeng

swordfeng commented Aug 3, 2016

Copy link
Copy Markdown
Contributor Author

@LionNatsu
I did not go deeply into the code... It seems that the previous PR just works well.
I'll be happy if you decide to do some further work.

Comment thread curses.c
mtrtype = IPPROTO_ICMP;
break;
}
return ActionNone;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new feature: here's a new switch key s for SCTP

@LionNatsu LionNatsu Aug 3, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it will surely not work. s conflicted with line 135, the key to Change Packet Size.

@LionNatsu

Copy link
Copy Markdown

BTW, why does TCP not emit SIGPIPE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants