test(split): cover closed stdin exit#641
Merged
Merged
Conversation
Komzpa
force-pushed
the
darafei/split-nohup-test
branch
from
8484938 to
dc448bf
Compare
Komzpa
force-pushed
the
darafei/split-nohup-test
branch
from
dc448bf to
5666b9f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/dev/nullmtr --split -c 1exits instead of spinning on a readable closed stdin fdFixes #231.
The runtime behavior is already protected by the current
isatty(STDIN_FILENO)guard inui/split.c; this PR keeps that historical nohup failure mode covered by the command parser test suite.Tests
git diff --check./bootstrap.sh && ./configure --without-gtk --without-jansson && make -j "$(nproc)"sudo python3 ./test/cmdparse.py