Repository navigation
Workbench task with geometry links - #269
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 97185a4. Configure here.
added 3 commits
September 23, 2026 07:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
source_id) with their own placement, separate from Design bodies.Shape_id, and cross-section clip keeps each survivor's id, so Workbench instances update instead of disappearing. Consumed operands still drop their links. Those booleans reject Workbench instances.Shape_remove_deltarecords the cascaded links, so undo restores them..ezymodeslots 1, 3, and 24 stay Design Move / Rotate / Align shafts. Workbench Move / Rotate / Align shafts use new slots, so a file saved in the old Design tools does not open in Workbench.Closes #268
Test plan
EzyCad_tests --gtest_filter=Shp_test.Cut*:Shp_test.Fuse*:Shp_test.Common*:Shp_test.Undo_delete_design_restores_workbench_links:Shp_test.Design_geom_change_syncs_workbench_link:Shp_test.Workbench_json_round_trip_and_source_delete:Mode_helpers*Note
High Risk
Changes core document semantics (dual shape stores, boolean id reuse, mode enum/slots), persistence, and transform behavior across Design vs Workbench—regressions would affect saved projects and assembly-style workflows.
Overview
Introduces a Sketch / Design / Workbench task model: the toolbar has task switchers and only shows tools for the active task. Design still edits bodies in the Shape List (move/rotate/scale/align bake BREP); Workbench arranges linked instances in a new Workbench List pane (
m_wbk_shps, persisted as.ezyworkbench[]withsourceId+ frame, no duplicate BREP).Add to Workbench (button, context menu, or drag) creates placements that track Design geometry when the same
Shape_idsurvives edits. Cut, fuse, common, and cross-section clip now reuse the first/survivor operand id where appropriate;Shape_replace_deltaavoids dropping links when the same id is re-inserted. Workbench Move / Rotate / Align shafts update instance pose only; G/R/J follow the current task; S stays Design Scale. Idle modes rename toDesign_inspection/Sketch_inspection(legacy names still parse).Also ships Workbench toolbar/list polish (face pick, set frame, task sync on list selection), align-shafts default axial sense, extrude on the Sketch task, changelog fixes (transform mid-drag, sketch overlaps, wasm link), docs/agent plans, and the Workbench task icon.
Reviewed by Cursor Bugbot for commit cdcf2d1. Bugbot is set up for automated code reviews on this repo. Configure here.