fix: add timeout to WASM plugin verification to prevent indefinite blocking#147
Merged
Conversation
mloiseleur
approved these changes
Apr 23, 2026
mloiseleur
force-pushed
the
fix/wasm-timeout
branch
from
4b7c114 to
534b5f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
runWithTimeouthelper that wraps any function with a hard timeout via goroutine +select, since wazero does not respectcontext.Contextdeadlines during module instantiationcheckWasmMiddlewarewith a 10s timeout (aligned with the existing Yaegi verification timeout), preventing piceus from hangingindefinitely when a WASM plugin makes blocking network calls during initialization
context.ContextintocheckWasmMiddlewarefor future-proofing, even though wazero currently ignores itFixes #146