Repository navigation
test: Verify chunk-at-a-time streaming deterministically - #3777
Merged
bdarnell merged 1 commit intoOct 7, 2026
Merged
Conversation
test_chunked and test_header_callback relied on a 10ms sleep between chunks to get [b"asdf", b"qwer"] in the streaming callback. Now that chunks arriving together are coalesced, that was timing-dependent and failed on Windows. Instead, have ChunkHandler wait until the client's streaming_callback has received the first chunk before sending the second. A client that held data back would now fail the test instead of passing it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019XKZM6XMVNYGibRyDU6QZW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_chunked and test_header_callback relied on a 10ms sleep between chunks to get [b"asdf", b"qwer"] in the streaming callback. Now that chunks arriving together are coalesced, that was timing-dependent and failed on Windows. Instead, have ChunkHandler wait until the client's streaming_callback has received the first chunk before sending the second. A client that held data back would now fail the test instead of passing it.
Claude-Session: https://claude.ai/code/session_019XKZM6XMVNYGibRyDU6QZW