Repository navigation
Accept absolute-form request targets - #3764
Open
Shaisolaris wants to merge 2 commits into
Open
Shaisolaris wants to merge 2 commits into
Shaisolaris wants to merge 2 commits into
Conversation
Rewrite an absolute-form request-target to origin-form and take the host from the target, per RFC 9112 section 3.2.2.
Cover host replacement, a missing path, IPv6, and a raw request that used to 404.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1036.
RFC 9112 section 3.2.2 requires an origin server to accept an absolute-form request-target and to use that target's host instead of the Host header. Tornado treated GET http://host/app HTTP/1.1 as a path, so the request 404'd.
HTTPServerRequest now rewrites absolute-form to origin-form and takes the host from the target. Origin-form, authority-form, and asterisk-form are unchanged. A proxy that routed on the raw request-target will see the path after this, which is the origin-server behavior the issue asked for.