Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,6 @@
## 2026-09-19 - Avoid chained array methods before Set initialization
**Learning:** Chaining `.map().filter()` inside a `new Set()` constructor creates multiple intermediate arrays, causing unnecessary memory allocation and garbage collection overhead in hot paths (like ticker normalization during discovery).
**Action:** Replace chained array methods with a direct indexed `for` loop that transforms, validates, and `.add()`s directly to a freshly initialized `Set`.
## 2026-10-01 - Optimize ticker extraction in backtest hot loop
**Learning:** In hot loops like the backtest runner, chaining declarative array and Set methods (e.g., `Array.from(new Set([...arr1, ...arr2]))`) creates unnecessary intermediate arrays and causes GC overhead. Even with small arrays, these micro-allocations add up in tight loops.
**Action:** Use imperative bounded `for` loops with early-exit conditions and a tracking `Set` to prevent unnecessary iteration and allocations. While this slightly increases code verbosity, the performance trade-off is often justified in critical simulation paths.
27 changes: 23 additions & 4 deletions src/agent/backtestRunner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -347,10 +347,29 @@ export async function runBacktestSession(
universe: BACKTEST_DISCOVERY_UNIVERSE,
limit: maxCandidates,
});
const held = (await broker.snapshot()).positions.map((p) => p.ticker);
const tickers = Array.from(
new Set([...held, ...discovery.candidates.map((c) => c.ticker)]),
).slice(0, maxCandidates);
const snapPositions = (await broker.snapshot()).positions;
const tickers: string[] = [];
const seen = new Set<string>();

for (let i = 0; i < snapPositions.length; i++) {
const ticker = snapPositions[i]!.ticker;
if (!seen.has(ticker)) {
seen.add(ticker);
tickers.push(ticker);
if (tickers.length >= maxCandidates) break;
}
}

if (tickers.length < maxCandidates) {
for (let i = 0; i < discovery.candidates.length; i++) {
const ticker = discovery.candidates[i]!.ticker;
if (!seen.has(ticker)) {
seen.add(ticker);
tickers.push(ticker);
if (tickers.length >= maxCandidates) break;
}
}
}

const decisions: FinalDecision[] = [];
for (const ticker of tickers) {
Expand Down
Loading