Update to 2018 data#41
Open
atomicpages wants to merge 1 commit into
Open
Conversation
atomicpages
commented
Jan 2, 2024
| #!/bin/bash | ||
|
|
||
| rm -rvf *-10m.json | ||
| PATH=$PATH:./node_modules/.bin: |
Author
There was a problem hiding this comment.
Load $PATH variables from node bin. This ensures the scripts works on any machine after yarn install is run
| rm -rvf *-10m.json | ||
| PATH=$PATH:./node_modules/.bin: | ||
|
|
||
| rm -rvf *-10m.json build |
Author
There was a problem hiding this comment.
Clean build folder as well ✌️
|
Thank you for this change! Can we update the .env year to 2024? There were some US county changes that happened in the 2020 census so it'd be good to move things to post-2020. Just to keep stuff up-to-date. I tested setting YEAR to 2024 on my fork and was able to generate the county/state/nation/albers files. @mbostock is it possible to get a review here? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #34 by moving to 2018 data files. In addition to this fix, the year can now be controlled via
.envfile containing theYEARenvironment variable. I tested using 2022 as well and everything appears to be in order. If there's interest I'd be happy to setupsemantic-releaseand other github actions to help automate keeping this project up to date! Let me know 🚀