Repository navigation
PM-6783 / PM-6784: goods-sold controls and calculator challenge fee - #2650
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-6783
https://topcoder.atlassian.net/browse/PM-6784
What's in this PR?
The calculator now shows Challenge fee = Booking Cost − Total Member Cost instead of the actual-cost hourly rate in the Member Cost summary. Referral fees are included in Total Member Cost; missing inputs remain unavailable, and zero/negative differences are preserved.
Goods Sold Customer-Wise gains inclusive From/To dates, multiple offering selections, Apply/Reset controls, and Member Payment / Booking Cost measures. Applied filters load independently of the other dashboards. Dates become half-open UTC API bounds and respect the API's 24-month limit; filtered totals are labeled Period total. Requests support cancellation and retry, and both measures retain monthly/quarterly aggregation and customer-table sorting/expansion. Quarter headers include years when needed to distinguish repeated quarters.
Companion API and rollout
reports-api-v6 #221 supplies
filterOptions.offeringType,customerBookingCosts, and filtering before payment aggregation. Deploy the API before this UI. No database migration is required. Missing booking costs display an unavailable message rather than member-payment totals.The Reports development Salesforce OAuth configuration currently returns
invalid_client_id; the deployment environment needs working existing Salesforce configuration/read permissions for offering lookups. The API retains unfiltered amounts with an explicit notice if Salesforce is unavailable. Deployed credentials were not changed.The calculator fix is isolated in commit
04ea9a732and has no API dependency.Validation
tsc --noEmitpassed on the final code.git diff --checkpassed.