Skip to content

fix: remediate community image scan findings - #7299

Merged
jmgasper merged 1 commit into
developfrom
fix/dev-image-scan-findings
Nov 6, 2026
Merged

jmgasper merged 1 commit into
developfrom
fix/dev-image-scan-findings

Conversation

@jmgasper

@jmgasper jmgasper commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

The dev deployment is blocked by image scan findings from bundled upstream development lockfiles and two installed dependencies: deepmerge 4.3.1 and elliptic 6.6.1.

  • Replace deepmerge 4 with a documented local MIT-licensed fork that rejects prototype-related keys on both inputs, writes own data properties, and fails closed on throwing membership checks. Keep older deepmerge consumers unchanged. Includes source integrity, license, and security/compatibility regressions. Advisory.
  • Replace the broad crypto-browserify fallback with the hashing, HMAC, and random-number browser APIs the application uses. This removes unused signing/ECDH dependencies, including elliptic, from the installed graph. Server code continues to use native Node crypto. Add tests comparing browser HMAC/hash output with Node and exercising random API contracts. Elliptic advisory.
  • Exclude the standalone automated smoke-test project from Docker context and remove four unused dependency-local development lockfiles from both runtime targets. Retain installed code, package manifests, and the app lockfile for scanning.

Validation:

  • Frozen npm install, JS/SCSS lint, 179 passing application suites (527 tests; 16 existing skips), and all 153 snapshots.
  • Security tests: 8 deepmerge regressions, 11 Node security tests (including 3 browser crypto tests), and 7 Jest security tests.
  • Both development and production Docker targets build successfully, including browser bundle syntax and retired-CMS checks.
  • Both final images start successfully and return HTTP 200 for the manifest and auth popup script. Image inspection confirms the patched dependency graph and removal of the unused files while retaining package manifests.
  • Fresh local Trivy scans of both final images report zero MEDIUM, HIGH, or CRITICAL findings. AWS ECR/Inspector will independently scan the deployment image after merge.

The deepmerge fork is temporary; replace it with a reviewed upstream fix when available.

@jmgasper
jmgasper requested a review from kkartunov as a code owner November 6, 2026 05:21
@jmgasper
jmgasper merged commit 162c6d0 into develop Nov 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant