Repository navigation
Conversation
What was broken The production build has failed since the October 2026 Release 3 merge, so the PM-6601 angle-bracket fix never reached production. CircleCI build-prod #18513 stopped at npm test with community-csp.js reporting "Unauthorized" from the groups service. Develop build-dev and branch test jobs fail the same way, so develop is not deploying either. Root cause The JoinCommunity container test mounts the Terms container, which loads metadata for community "1" on every mount, and its join test dispatches the real joinDone action. joinDone posts to the live Groups API through topcoder-react-lib's own fetch, which the test's global.fetch mock never intercepts. redux-mock-store does not settle action payloads, so the metadata failures and the 401 rejection stay unhandled. Jest 23 fails whichever spec is running when they arrive. In CircleCI that is the first community-csp.js case, which runs next in the same worker. The tc-communities actions test makes the same unauthenticated request when the file loads. What was changed Stub the groups service in both suites. Replace the Terms container with a null component in the container test, which only asserts on JoinCommunity actions. No application code changed. Any added/updated tests The actions test now verifies that the joinDone payload resolves through the groups service without a network request. This restores the assertion left commented out since topcoder-react-lib v0.3.0. Running the container and CSP suites in one worker failed 6 CSP tests before this change. Three runs after it pass with no leaked rejections. Validation: npm test (lint, stylelint, retired-CMS check, 495 passed, 23 already skipped, 141 snapshots) and npm run build pass under Node 10.24.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: PM-6601
What was broken
The PM-6601 fix (#7286) reached
masterin the October 2026 Release 3 merge (#7291), but production was never redeployed. build-prod #18513 failed innpm test, so no image was pushed. Production ECS is still oncommunity-app:18501from 2026-10-08. The live article still shows<TesterClassName>, while dev renders<TesterClassName>.The same test fails in develop
build-dev(#18511, #18516) and in the PM-6628 branchtestjob (#18510).Root cause
The failing test,
community-csp.js, was not the source of the error.__tests__/shared/containers/tc-communities/JoinCommunity.jsxleaves rejected promises behind:Termschild container loads metadata for community1on every mount, and that lookup fails.jointest dispatches the realjoinDone. That posts to the live Groups API through topcoder-react-lib's own fetch, so the test'sglobal.fetchmock never sees it, and the unauthenticated request gets a 401.redux-mock-storedoes not settle action payloads. Jest 23 fails whichever spec is running when an unhandled rejection arrives. In CircleCI, the next file in that worker iscommunity-csp.js, so its first case gets theUnauthorized. The tc-communities actions test makes the same live request when the file loads.What was changed
Test-only:
containers/Termswith a null component. That test only asserts on JoinCommunity actions.No application code changed.
Tests
joinDonepayload resolves through the groups service without a network request. This restores the assertion left commented out since topcoder-react-lib v0.3.0.--runInBand) failed 6 CSP tests before this change. Three runs after it pass with no leaked rejections.Validation (Node 10.24.1)
npm teston the master-based hotfix: 175 suites, 495 passed, 23 already skipped, 141 snapshotsnpm run build: passedCherry-pick of #7293 (hotfix to
master) so developbuild-devdeploys resume. On this branch,npm testpassed (177 suites, 503 passed, 23 already skipped, 141 snapshots) andnpm run buildpassed.🤖 Generated with Claude Code