subscriber: use span fields for state attr updates#255
Closed
zaharidichev wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Zahari Dichev <zaharidichev@gmail.com>
Collaborator
Author
|
closing in favor of #264 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to follow the suggestions in #246 to redesign the state update logic.
This change enables us to start switching to this new approach in tokio while still maintaining
the old way of emitting state updates. Now we can simply drive state updates by creating and
recording fields that look like
state.field_name.unit.delta.Signed-off-by: Zahari Dichev zaharidichev@gmail.com