suggest a moops version of Yanick's deduper as an example#2
Open
mokko wants to merge 1 commit into
Open
Conversation
Owner
traits => ['Counter'], #doesn't work in Moops?This isn't going to work in a Moo class. Moops uses MooX::HandlesVia to implement attribute traits in Moo classes (because Moo doesn't have any native support for attribute traits). MooX::HandlesVia's documentation notes that because of the way Moo is implemented, this is only really useful for attributes where the values are references (i.e. arrayrefs, hashrefs, etc). Also, I think the Overall, I think it might be too long to serve as a useful example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't talk to Yanick. Just thought the recent award-winning piece of code might might be a good demo for moops's clean code. Perhaps also for performance.
I guess the file should make better reference to original author in case you want to include it. I just wanted to run it by you to see what you think.