Ignore bikeshed errors for merge base#178
Merged
Merged
Conversation
Contributor
Author
|
Test is failing because I forgot to fix the test expectation after refactoring to use the fixture. I'll fix that up and update the PR. |
Rob--W
force-pushed
the
ignore-bs-error-in-base
branch
from
33b9628 to
171d154
Compare
Rob--W
force-pushed
the
ignore-bs-error-in-base
branch
from
171d154 to
927edb2
Compare
Contributor
|
@tobie what do you think? |
Owner
|
LGTM. Missed that the tests had been fixed. |
Contributor
Author
|
Thanks for merging! What do I need to do to trigger the updated/latest version of pr-preview in w3c/webextensions#905 ? |
Owner
|
@Rob--W Just modifying the body of the PR on GH is enough to retrigger a build. You don't even need to push a change. |
Owner
|
Looks like it worked! Congrats and thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #177