Repository navigation
docs(agents): align persistence guarantees and command guardrails - #655
toasterbook88 wants to merge 6 commits into
Conversation
toasterbook88
left a comment
There was a problem hiding this comment.
AXIS Grok gate
Verdict: PASS-WITH-RISK
PR #655: docs(agents): align persistence guarantees and command guardrails
Head SHA: 012bf37
Files touched (3): AGENTS.md, .github/copilot-instructions.md, .claude/settings.json
Invariant hits: none.
- Docs/config only. No advisory override of fact plane, no lock-held confirm, no cache badge change, no secret/ssh/fleet/spawn/self-authorize/unattended write.
- Persistence note now matches observed recovery: only state.json/skills.json quarantine; other files surface load errors.
- Public-repo rule in Copilot instructions aligned with AGENTS.md §2 (tailnet/LAN, live ports, model/unit names).
- Claude Code deny list tightened with rmdir / git restore / git checkout -- (additional guardrails only).
CI status: CodeQL success, govulncheck success, Analyze (actions) success. Test & Build still in_progress. mergeable_state: blocked.
Recommended operator action: Wait for Test & Build to complete green. Then merge if the maintainer wants the instruction alignment. No product runtime change; safe to land once CI finishes. No APPROVE from this gate.
|
Re-review of commit 📋 Walkthrough (3 files)
Automatic re-reviews are paused on this PR after 3 reviews. Mention @testdriverai to get a fresh review of the latest commits. Was this review useful? React with 👍 or 👎 to help TestDriver improve. Want help from the team that built TestDriver? Explore TestDriver for Business |
The deny list covered deletion of files (`rm`, `unlink`, `shred`, `rmdir`), working-tree resets (`git restore`, `git checkout --`), and history rewrites pushed to a remote (`git push --force*`). Commands that discard local work without touching the remote were still allowed: a dropped or cleared stash, a force-deleted branch, `git filter-branch` / `git filter-repo`, a deleted ref, `truncate`, and `git checkout .` — which the existing `Bash(git checkout -- *)` rule does not match. `Bash(git update-ref -d *)` is on the list deliberately: it is the non-interactive equivalent of the blocked force-branch-delete, and it is how a ref is deleted when `-d` refuses a squash-merged tip. `Bash(git restore *)` stays broad rather than narrowed to `--worktree`. A prefix matcher cannot express "everything except `--staged`", and the default form (`git restore <path>`) discards the file's changes, so narrowing the rule to spare a harmless `git restore --staged` would open the path that matters.
Correct the persistence guidance: corrupt state and skills stores are quarantined,
while other persisted files can return load errors without quarantine. Align
Copilot's public-data rule with AGENTS.md and add Claude Code deny entries for
rmdir, git restore and path checkout commands.
These are the three remaining local instruction/config edits, carried into an
isolated branch without changing the original checkout.
Validation: checked the guidance against state/skills recovery and the reservation
ledger's read-only error path; JSON parsing and the existing Claude workflow tests
pass; full ci-preflight passes with Go 1.26.11. No product command or runtime API
changes are introduced.