Fix: reporting improvements#156
Open
ignasi42 wants to merge 2 commits into
Open
Conversation
ignasi42
force-pushed
the
fix/reporting-improvements
branch
from
76047e7 to
8158264
Compare
tnicola
approved these changes
Apr 26, 2023
tnicola
requested changes
Dec 3, 2023
tnicola
left a comment
tnicola
left a comment
Owner
There was a problem hiding this comment.
Thank you!Can you please revert the first change? (Using a fixed column width)
| head: ['Spec', 'Time', 'Tests', 'Passing', 'Failing', 'Pending'], | ||
| style: { head: ['blue'] }, | ||
| colWidths: [50, 8, 7, 9, 9, 9] | ||
| colWidths: [100, 10, 10, 10, 10, 10] |
Owner
There was a problem hiding this comment.
Thanks!A fixed width could not work for everyone, and people using small screens would end up seeing a messed up table. I think I found a better solution by making the width flexible based on the spec name length:
Line 58 in f758d45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.