fix(temp_window): Remove non-functional *args parameter#619
Open
tony wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #619 +/- ##
=======================================
Coverage 47.02% 47.02%
=======================================
Files 23 23
Lines 3296 3296
Branches 709 709
=======================================
Hits 1550 1550
Misses 1384 1384
Partials 362 362 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
dff674e to
8cb8b4d
Compare
why: Session.new_window() uses keyword-only arguments (has * marker after window_name), so temp_window() could not forward *args. Calling temp_window(session, "positional_arg") would raise TypeError. what: - Remove *args from temp_window() signature - Update docstring to remove args parameter documentation - Remove *args forwarding in session.new_window() call
8cb8b4d to
bd382df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*argsfromtemp_window()signature since it cannot be forwarded toSession.new_window()Problem
Session.new_window()uses keyword-only arguments (has a*marker afterwindow_name), which means it cannot accept positional arguments beyondwindow_name. However,temp_window()accepted*argsand attempted to forward them, which would cause aTypeErrorat runtime if anyone tried to pass positional arguments.Example that would fail before this fix:
Note:
temp_session()is unaffected becauseServer.new_session()explicitly accepts*args.Test plan