Skip to content

Separate out caml_startup-dependent code into runtime library#36

Open
mrmr1993 wants to merge 2 commits into
tizoc:masterfrom
mrmr1993:feature/runtime-as-separate-lib
Open

Separate out caml_startup-dependent code into runtime library#36
mrmr1993 wants to merge 2 commits into
tizoc:masterfrom
mrmr1993:feature/runtime-as-separate-lib

Conversation

@mrmr1993

@mrmr1993 mrmr1993 commented Aug 6, 2021

Copy link
Copy Markdown

This PR moves the utility functions for starting an OCaml runtime into their own library.

This is a trivial but breaking change. I've taken the liberty of bumping the version number accordingly.

This fixes #34.

Tested by:

  • running dune utop in an OCaml project using this library to generate a rust native library (via a tweaked ocaml-rs)
  • running make test-all

@tizoc

tizoc commented Aug 6, 2021

Copy link
Copy Markdown
Owner

@mrmr1993 at a first glance it looks good, but will re-check tomorrow. One thing, you have to bump the version of the root Cargo.toml file too.

About the commented function in the doctest, is it not possible to make that one work?

@mrmr1993

mrmr1993 commented Aug 6, 2021

Copy link
Copy Markdown
Author

One thing, you have to bump the version of the root Cargo.toml file too.

Done, good catch!

About the commented function in the doctest, is it not possible to make that one work?

It's the first time I've come across tests in this format, so I'm afraid I'm not sure. I strongly suspect not -- there doesn't seem to be any way to specify additional external deps for those tests -- but that doesn't mean there isn't one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linking error when running with dune utop

2 participants