Skip to content

Give tool_prefix back the documentation it already had - #77

Merged
sanil-23 merged 1 commit into
tinyhumansai:mainfrom
sanil-23:fix/tool-prefix-doc
Sep 23, 2026
Merged

sanil-23 merged 1 commit into
tinyhumansai:mainfrom
sanil-23:fix/tool-prefix-doc

Conversation

@sanil-23

Copy link
Copy Markdown
Collaborator

Summary

main has been red since #74: the Rust lane's clippy step and the Docs lane both fail on missing documentation for a method at EpisodeHost::tool_prefix. Every branch cut from main inherits it — #76 is failing on this and nothing else.

Nothing was ever missing. tool_prefix's doc block is intact; it sits above persona, fused to persona's own opening line with no blank line between them:

/// ... vocabulary, so a host that prefixes says so in its own prompt.
/// The seat's own standing prompt, for the turns that are not its first.
///
/// A seat's session is cleared and reseeded ...
fn persona(&self, seat: &str) -> Option<String> { ... }

fn tool_prefix(&self) -> String {   // ← bare
    String::new()
}

A merge slip rather than a gap: the prose describing the prefix still reads correctly, it is simply attached to the wrong method. Moving tool_prefix back under its own doc fixes both lanes and changes no behaviour.

Related issue

None. Found while investigating CI on #76, which is blocked by this and by nothing of its own.

API or behavior changes

None. One method moved a few lines up, under the documentation written for it. No signature, no default, no call site.

Validation

  • cargo fmt --all -- --check — exit 0
  • cargo clippy --all-targets --all-features -- -D warnings — exit 0 (this is the lane that has been failing)
  • cargo build --all-targets --all-features — exit 0
  • cargo test --all-features — exit 0, 36 targets, unchanged
  • cargo doc --no-deps --all-features — exit 0 (the other failing lane)

Tests

None added. The regression is a lint, and the two lints that caught it are the test — both were failing on main and both pass here.

Documentation

This is the documentation fix. No prose was written or changed; the existing block is simply reunited with the method it describes.

🤖 Generated with Claude Code

`main` has been red since tinyhumansai#74. The Rust lane's clippy step and the Docs
lane both fail on `missing documentation for a method` at
`EpisodeHost::tool_prefix`, and every branch cut from main inherits it.

Nothing was ever missing. `tool_prefix`'s doc block is intact -- it sits
above `persona`, fused to `persona`'s own first line with no blank
between them, and `tool_prefix` itself was left bare a few lines below.
A merge slip, not a gap: the prose describing the prefix still reads
correctly, just over the wrong method.

Moving the method back under its own doc fixes both lanes.
`cargo clippy --all-targets --all-features -- -D warnings` and
`cargo doc --no-deps --all-features` are exit 0, and the suite is
unchanged at 36 targets.
@tinysweeper

tinysweeper Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Ready for maintainer review
Priority: none
Reviewed head: 75c66143885c
Updated: 1790202644 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 1 Active findings 0
Tests 0 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 0 Pending checks/questions 0

Completeness: Complete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Before merge

None.

How this fits together

flowchart LR
  n0["turn"]:::impacted
  n1["new"]:::impacted
  n2["HostedSeat"]:::impacted
  n3["EpisodeHost"]:::impacted
  n4["HostedRunner"]:::impacted
  n5["seat"]:::impacted
  n0 -->|calls| n1
  n4 -->|uses| n2
  n4 -->|uses| n3
  n5 -->|calls| n1
  n5 -->|uses| n2
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Loading
Agent review details

critique

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change only relocates the default `tool_prefix` implementation without changing its behavior or the public contract. It is safe to merge. _The code index is behind this pull request (indexed at `cd23c7fed5b0`), so retrieved context may be out of date._ _5 memory call(s) failed (model: cortex: v1/recall: timed out after 10s), so this review saw part of what the engine holds._

security

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: The change only relocates the default `tool_prefix` implementation within the trait implementation; behavior is unchanged and the change is safe to merge. _The code index is behind this pull request (indexed at `cd23c7fed5b0`), so retrieved context may be out of date._ _5 memory call(s) failed (model: cortex: v1/recall: timed out after 10s), so this review saw part of what the engine holds._

tests

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Reorders the `tool_prefix` method in `EpisodeHost` trait to appear earlier and adds a default implementation returning `String::new()`. This is a purely additive change — existing implementors already provide their own `tool_prefix` and are unaffected, and new implementors get a safe default. No behaviour regresses and no test is needed. _The code index is behind this pull request (indexed at `cd23c7fed5b0`), so retrieved context may be out of date._ _5 memory call(s) failed (model: cortex: v1/recall: timed out after 10s), so this review saw part of what the engine holds._

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Moves `tool_prefix` under its documented doc block, fixing clippy and doc build failures with no behavior change. Safe to merge. _The code index is behind this pull request (indexed at `cd23c7fed5b0`), so retrieved context may be out of date._ _5 memory call(s) failed (model: cortex: v1/recall: timed out after 10s), so this review saw part of what the engine holds._

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No end-to-end harness in this repository: no e2e test files and no e2e workflow.
Evidence and run details
  • Models: ladder/vectors, gpt-5.6-luna, deepseek-v4-flash
  • Spend: $0.001522
  • Tokens: 55306 input · 2954 output · 3584 cached · 50 embedding
Head State Pass summary
75c66143885c ready for maintainer review 0 active finding(s), 0 resolved finding(s) (at 1790202644)

tinysweeper 0.1.0

@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 30 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 24039ae0-bf99-4325-be05-679f0db2637f

📥 Commits

Reviewing files that changed from the base of the PR and between dc3acec and 75c6614.

📒 Files selected for processing (1)
  • crates/tinyhivemind-openhuman/src/hosted/mod.rs

Comment @coderabbitai help to get the list of available commands.

@sanil-23
sanil-23 merged commit b628543 into tinyhumansai:main Sep 23, 2026
6 checks passed

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking. Approving.

             $0.0015 · 55,306 in / 2,954 out · 3,584 cached (6%)  · ladder/vectors, gpt-5.6-luna, deepseek-v4-flash · 50 embedded
critique:    $0.0002 · 15,715 in / 101 out   · 0 cached (0%)      · gpt-5.6-luna
security:    $0.0008 · 15,471 in / 159 out   · 0 cached (0%)      · gpt-5.6-luna
tests:       $0.0003 · 15,554 in / 362 out   · 2,048 cached (13%) · deepseek-v4-flash
description: $0.0001 · 6,914 in  / 525 out   · 1,536 cached (22%) · deepseek-v4-flash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant