Refactor#3
Merged
Merged
Conversation
…line lockfile parsing
There was a problem hiding this comment.
Pull request overview
Refactors the CLI implementation by inlining lockfile parsing into main.rs and extracting reusable HTTP/JSON and retry helpers into the crates.io API client, reducing duplicated request/retry logic.
Changes:
- Inlined
Cargo.lockparsing intosrc/main.rsand removed the dedicatedlockfilemodule. - Extracted a generic
fetch_jsonhelper and awith_retryretry wrapper insideCratesIoClient. - Moved per-package publish-date evaluation into a
check_packagehelper.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main.rs | Inlines lockfile parsing and factors package checking into a helper. |
| src/api.rs | Adds fetch_json + with_retry helpers and rewires publish-date/version fetching through them. |
| src/lockfile.rs | Removes the standalone lockfile parsing module after inlining into main.rs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract fetch_json/with_retry helpers and check_package, inline lockfile parsing.