Refresh wallet balance more regularly.#26
Open
lexzaiello wants to merge 2 commits into
Open
Conversation
bekauz
approved these changes
Oct 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, there is a bug in Osmosis trades which causes transactions to fail to execute, due to the wallet balance being lower than the execution plan specifies. The only explanation for this is that the execution plan is being created with a stale starting amount (wallet balance). One possible explanation for this behavior is rebalancing in between wallet balance fetching and route evaluation. This PR refreshes the wallet balance after rebalancing to remedy this issue.
Note: This will not fix the underlying issue - wallet funds getting stuck somewhere before the trade is executed. Further testing will be done to verify the source of this behavior.