Release v1.2.0#358
Conversation
|
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — mechanical release version bump from 1.2.0-dev to 1.2.0.
Extended reasoning...
Overview
This is a standard release PR cutting v1.2.0 from v1.2.0-dev. The changes are purely mechanical version-string updates produced by ./scripts/bump-version.sh 1.2.0-dev 1.2.0:
- Version strings in
pg_textsearch.control,Makefile,CLAUDE.md,README.md,src/mod.c(PG_MODULE_MAGIC_EXT) - SQL install/upgrade scripts renamed and re-stamped (
pg_textsearch--1.2.0.sql,pg_textsearch--1.1.0--1.2.0.sql) — the upgrade script is just a library-version check, no new catalog objects - Banner image swap (
tapir_and_friends_v1.1.0.png→v1.2.0.png) - Upgrade-test matrix gains
1.1.0so the new release tests upgrades from the immediately prior version - Test scripts updated to
CREATE EXTENSION ... VERSION '1.2.0'and benchmark version check updated
Security risks
None. No logic changes, no permission/auth changes, no new SQL-callable functions. The library-version mismatch check in the install script is unchanged in behavior.
Level of scrutiny
Low — this is the canonical release-cut PR pattern. The release checklist is complete, the upgrade SQL is a no-op (no new catalog objects between 1.1.0 and 1.2.0-dev), and make installcheck reportedly passes (61/61). The upgrade-tests workflow will exercise the 1.1.0 → 1.2.0 path in CI before release artifacts are published.
Other factors
The renamed SQL file (1.1.0--1.2.0.sql) is consistent with the Makefile DATA list and the install script's version-equality check. The version string in src/mod.c matches PG_TEXTSEARCH_VERSION set in the Makefile from pg_textsearch.control, so the loaded-library version GUC will report 1.2.0 consistently.
Follow-up to the v1.2.0 release (#358), per the playbook in [RELEASING.md](RELEASING.md). Generated via: ```sh ./scripts/bump-version.sh 1.2.0 1.3.0-dev ``` Renames the main install SQL to `sql/pg_textsearch--1.3.0-dev.sql`, creates the library-version-check stub at `sql/pg_textsearch--1.2.0--1.3.0-dev.sql` (contributors append to this as features land), and bumps the version reference in `pg_textsearch.control`, `Makefile`, `src/mod.c`, `README.md`, `CLAUDE.md`, and the test/benchmark scripts that pin the expected version. The remaining literal `1.2.0` occurrences flagged by the bump script are intentional historical references (on-disk bm25vector v1→v2 migration notes in `src/types/vector.{c,h}` and `test/sql/vector_v1_rejected.sql`, plus the legacy `1.1.0--1.2.0` upgrade SQL filename in `Makefile` DATA) and are left unchanged. Verified locally: `make` builds clean against pg17. Per `RELEASING.md`, this PR should land before the Wikipedia-validation PR (#372) is merged.
2 participants
Release v1.2.0.
Release checklist
sql/pg_textsearch--1.1.0--1.2.0.sql): no new catalog objects between 1.1.0 and 1.2.0-dev; library version check only../scripts/bump-version.sh 1.2.0-dev 1.2.0.images/tapir_and_friends_v1.1.0.png, addedimages/tapir_and_friends_v1.2.0.png.1.1.0toold_versionmatrix in.github/workflows/upgrade-tests.yml.make installcheck— 61/61 tests passing locally on PG18.After merge,
release.ymlwill tagv1.2.0and publish artifacts.