Add Imperial / Metric options to dashboards

[bendavidson]

No description provided.

[tillsteinbach]

Just want to let you know that I did not forget this MR, I am just super busy right now. Sorry

[bendavidson]

No rush - I hadn't realised that the later commits would get included TBH (we use BitBucket rather than GitHub here)!

…

On Wed, 14 Sept 2022 at 13:43, Till Steinbach ***@***.***> wrote: Just want to let you know that I did not forget this MR, I am just super busy right now. Sorry — Reply to this email directly, view it on GitHub <#327 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPATD5UU2AXAHXM6JCG6FDV6HB6PANCNFSM6AAAAAAQIYATOU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[tillsteinbach]

If I saw it right, the function is only created in the migration script. For new users the function would also needed to be created (e.g. when the table is being created).

[bendavidson]

Sorry, took me a while to work out how alchemy actually works - latest commit will create the DB function for new databases

[WillScott73]

If I take this fork, will I lose all the data that I have already collected? Or does this version work with data stored in metric, and convert it to imperial for display only?

[bendavidson]

No, this only affects the display of the data in Grafana, not the data itself. It does touch the database to add the conversion function, but it doesn't change the data. At the moment, only some dashboards have the conversion on them, but now I have the 3.2 software I'll look to change the others which are now useful.

…

On Thu, 19 Oct 2023 at 06:19, Will Scott ***@***.***> wrote: If I take this fork, will I lose all the data that I have already collected? Or does this version work with data stored in metric, and convert it to imperial for display only? — Reply to this email directly, view it on GitHub <#327 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPATD2BAARMPTDABNQHDGLYACZ7TAVCNFSM6AAAAAAQIYATOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRZHE4TAOJXG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[motorto]

As a heads up, you should probably use git rebase instead of git merge. Rebase doesn't create these 'Merge Branchs' Commits.

[bassmandan]

Is there any likelihood this will be merged into main any time soon? I've just picked up an ID7 and this gives some amazing data but being British I'd prefer imperial units. Otherwise, how can I switch over to use this fork without losing all my data?

[Scoobdriver]

Is there any likelihood this will be merged into main any time soon? I've just picked up an ID7 and this gives some amazing data but being British I'd prefer imperial units. Otherwise, how can I switch over to use this fork without losing all my data?

@bassmandan did you figure this out, looking to do the same (Same car :) )

[bassmandan]

I never played about with it, although I did end up splitting the DB, VWsfriend and grafana instances out (running most on proxmox) so assume I could just replace the vmwsfriend container with this fork.

Otherwise, you should be able to replace the image for vwsfriend in the docker compose file with the one from the fork and it shouldn't impact any stored data.

[tillsteinbach]

Hey! I will probably not take the effort anymore to merge this. VWsFriend will become CarConnectivity a rewrite of the original idea. And there I implemented to deal with imperial/metric right from the beginning.