Small fix for potential js error when rendering locally-stored export data.#521
Open
clintonium-119 wants to merge 5 commits into
Open
Small fix for potential js error when rendering locally-stored export data.#521clintonium-119 wants to merge 5 commits into
clintonium-119 wants to merge 5 commits into
Conversation
Release 1.36.0 to master
Release 1.36.1 to master
Release 1.37.0 to master
This was referenced Jan 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a potential runtime error when rendering annotations from locally-stored export data (e.g., rawData.json) by safely handling missing code fields.
Changes:
- Guarded
stats-prefix checks against missingannotation.codevia optional chaining in the annotations renderer. - Bumped the package version to a local-data focused prerelease identifier.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates version string to reflect the local data source fix. |
| js/plot/util/annotations/annotation.js | Prevents TypeError from calling .slice() when annotations[0].code is missing/null by using optional chaining. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports using the local/rawData.json that we use for viz dataUtil exporation withing Tidepool Web patient data views
Related PRs:
tidepool-org/blip#1846
tidepool-org/viz#584