fix(network): narrow depends_on to stop plan-time replacements - #278
Merged
Merged
Conversation
Module-level depends_on on modules with pending changes defers every data source inside the dependent module to apply time. Changing cluster_names (which only retags the VPC and subnets) therefore made the S3 endpoint's aws_region lookup unknown and forced replacement of the VPC endpoint. - s3_endpoint: drop depends_on; route_table_ids already orders it after the route tables - nat_gateway / public_subnet_routes: drop module.public_subnets from depends_on; subnets are already passed by value. Keep the internet gateway dependency, which is still required. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module-level depends_on on modules with pending changes defers every data source inside the dependent module to apply time. Changing cluster_names (which only retags the VPC and subnets) therefore made the S3 endpoint's aws_region lookup unknown and forced replacement of the VPC endpoint.