add load_defaults option to example_app#2949
Merged
Merged
Conversation
goosys
force-pushed
the
fix/load_defaults
branch
from
8296493 to
8aff034
Compare
goosys
changed the title
Contributor
Author
goosys
force-pushed
the
fix/load_defaults
branch
from
8aff034 to
28c4191
Compare
Contributor
Author
|
goosys
force-pushed
the
fix/load_defaults
branch
2 times, most recently
from
37fa665 to
198f6cf
Compare
By enabling the correct set of defaults to be loaded with each Rails
version, we expect to get more accurate tests. By a nice addition, this
also fixes deprecation warnings we see, such as:
DEPRECATION WARNING: `config.active_support.to_time_preserves_timezone` is
deprecated and will be removed in Rails 8.2 (called from <top (required)> at
/workspaces/administrate/spec/example_app/config/environment.rb:5)
This also fixes some specs which failed because of the change.
nickcharlton
force-pushed
the
fix/load_defaults
branch
from
d04ec73 to
d27ddcf
Compare
Member
|
Thanks! I eventually got around to looking at this properly and merging it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure tests run correctly on each Rails version, I think it's better to set
load_defaultsaccordingly.I tried setting it, but it resulted in a large number of errors. I plan to fix them gradually over time.
Once all errors are resolved, I will open a PR.
If you have any concerns or a different direction in mind, please let me know.