RTK Query migration#1
Open
mcoughlin wants to merge 1 commit into
Open
Conversation
…rces from query hooks
The RTK Query migration (skyportal #6209) removed the `groups`, `source`, and
`sources` redux slices, but the BOOM alert components still read them via
useAppSelector (state.groups.userAccessible/.all, state.source, state.sources.latest).
Those now resolve to undefined -> TypeError on render -> the alerts list and
detail pages render blank, failing every boom frontend test.
Read them from the RTK Query hooks instead, matching skyportal's own migrated
pattern:
- groups -> useGetGroupsQuery().data?.{userAccessible,all} ?? []
- source -> the useLazyGetSourceQuery() result's .data
- sources -> the useLazyFetchSourcesQuery() result's .data
The base PR converted the dispatchable thunks (fetchSource/checkSource/fetchSources)
to lazy-query triggers but left these selectors pointing at the removed slices.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RTK